Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-4844-pectra (collect blob gas fee) #51

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Add EIP-4844-pectra (collect blob gas fee) #51

merged 2 commits into from
Oct 28, 2024

Conversation

dapplion
Copy link
Member

Adds a new pseudo-EIP for pectra modifying the Gnosis adaptation of EIP-4844 introduced in dencun

@Marchhill
Copy link

This matches the implementation in the Nethermind client (NethermindEth/nethermind#6866)

@filoozom filoozom self-assigned this Sep 10, 2024
filoozom
filoozom previously approved these changes Sep 10, 2024
@filoozom filoozom removed their assignment Sep 10, 2024
@Marchhill
Copy link

Is it likely we would ever want to send burned blob fees to a different address? Otherwise we could reuse the EIP1559_FEE_COLLECTOR constant

@dapplion dapplion changed the title Add EIP-4844-B (collect blob gas fee) Add EIP-4844-pectra (collect blob gas fee) Sep 12, 2024
@dapplion
Copy link
Member Author

@Marchhill Since EIP1559_FEE_COLLECTOR is an existing config variable, let's use EIP4844_FEE_COLLECTOR for now. We can discuss collapsing both into a FEE_COLLECTOR config variable but need to deal with backwards compatibility.

@dapplion dapplion merged commit 2c432ce into master Oct 28, 2024
2 checks passed
@dapplion dapplion deleted the eip-4844-b branch October 28, 2024 13:19
yperbasis added a commit to erigontech/erigon that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants